Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove function call for String#bytesize #8389

Merged
merged 2 commits into from
Sep 7, 2023
Merged

Remove function call for String#bytesize #8389

merged 2 commits into from
Sep 7, 2023

Conversation

tenderlove
Copy link
Member

String size is stored in a consistent location, so we can eliminate the function call.

@tenderlove
Remove function call for String#bytesize
294d200 
String size is stored in a consistent location, so we can eliminate the
function call.
@matzbot matzbot requested a review from a team September 6, 2023 23:18
k0kubun
k0kubun reviewed Sep 6, 2023
View reviewed changes
yjit/src/codegen.rs Outdated Show resolved Hide resolved
@maximecb @k0kubun
Update yjit/src/codegen.rs
1533850 
Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
maximecb
maximecb approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@maximecb maximecb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@maximecb maximecb merged commit 0adca62 into ruby:master Sep 7, 2023
94 checks passed
@tenderlove tenderlove deleted the string-bytesize-nofunc branch September 7, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximecb maximecb maximecb approved these changes

@k0kubun k0kubun k0kubun approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
3 participants
@tenderlove @maximecb @k0kubun